Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Construct and pass NAC #2630

Merged
merged 5 commits into from
Aug 20, 2024
Merged

[ENH] Construct and pass NAC #2630

merged 5 commits into from
Aug 20, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Aug 3, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • NAC is another enum type of the storage abstraction that gets constructed from the config on startup. Introduced config as well in this PR.

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@sanketkedia sanketkedia mentioned this pull request Aug 3, 2024
Merged
1 task
@sanketkedia Graphite App
Copy link
Contributor Author

sanketkedia commented Aug 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanketkedia and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia sanketkedia changed the title Construct and pass NAC [ENH] Construct and pass NAC Aug 3, 2024
@sanketkedia sanketkedia marked this pull request as ready for review August 3, 2024 11:11
This was referenced Aug 3, 2024
Merged
Closed
HammadB
HammadB approved these changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense thanks. Do we anticipate needing any configuration on the NAC? If so it should impl configurable. Maybe this will happen natrually when we implement the rate limiting.

I think we should consider making NAC more of a storage wrapper, which i think it is 75% of the way to being today.

@sanketkedia sanketkedia mentioned this pull request Aug 4, 2024
Merged
1 task
@sanketkedia sanketkedia force-pushed the 08-03-construct_and_pass_nac branch 2 times, most recently from 2253a87 to 5737fed Compare August 9, 2024 18:51
HammadB
HammadB reviewed Aug 15, 2024
View reviewed changes
rust/storage/src/lib.rs Outdated Show resolved Hide resolved
HammadB
HammadB approved these changes Aug 15, 2024
View reviewed changes
rust/storage/src/local.rs Show resolved Hide resolved
rust/worker/src/config.rs Show resolved Hide resolved
@sanketkedia sanketkedia force-pushed the 08-03-construct_and_pass_nac branch 2 times, most recently from 59ecf3e to 624aad0 Compare August 16, 2024 20:44
@sanketkedia sanketkedia changed the base branch from 08-03-introduce_nac to main August 20, 2024 00:09
@sanketkedia sanketkedia merged commit d48f4fd into main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

@Ishiihara Ishiihara Awaiting requested review from Ishiihara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB